Hi judith p,
welcome to the Apple (user-to-user) Community.
Re: "Apple ID not working correctly in app store / It comes up with an old apple id and wants me to sign in"
You might want to check that you are signed in (to your iPad) with your current ID:
Sign in with your Apple ID - Apple Support
Else: if all is Ok there:
Try signing in to your Apple ID account online to make sure your details there are up-to-date:
Apple ID Log-in:
https://appleid.apple.com/
If needed: Get a verification code and sign in with two-factor authentication - Apple Support
Also: Check there are no restrictions set for the App Store (ie: any that you do not want):
Manage App Store purchases, subscriptions, settings, and restrictions on iPad - Apple Support
If you make changes, you may need to allow 24 hours for those changes to update everywhere.
(If you want, you can try re-starting your iPad Pro: How to: Restart your iPad - Apple Support)
_____________________________________________________________________________________________
Trouble-shooting:
What to do: If you can’t download or update apps on your iPhone or iPad - Apple Support
_____________________
More Support if needed:
(There is a "Get Support" link (or use the support app) at the bottom of the two websites (links below)
App Store - Official Apple Support
Apple ID - Official Apple Support
All the best :-)